fix(gsm-compose): route gateway traffic on Docker network - #372
Merged
Conversation
Adamskiee
changed the title
Adamskiee
force-pushed
the
bugfix/gsm-compose-networking
branch
from
August 15, 2026 12:34
ae80eca to
930792a
Compare
7 tasks
Adamskiee
added a commit
that referenced
this pull request
Aug 16, 2026
…rict environment config This release merges the latest changes from `develop` into `main`, bringing in significant enhancements and bug fixes across the server, GSM module, and mobile components. Key Changes: GSM & Networking: - GSM Emulator: Added a new virtual modem development stack for testing without physical hardware (#373). - GSM Security & Routing: Secured SMS delivery (#362), required verified phone numbers for outgoing SMS (#375), and routed gateway traffic correctly on the Docker network (#372). Server & Environment: - Typed Configuration: Introduced strict typed environment configuration (#363), failing fast when GSM_SECRET is unset (#361), and replacing example secrets in configs (#366). - API & Data Integrity: Hardened error handling logs, made role writes atomic (#377), ignored activity writes for deleted users (#374), and hardened QA route guards (#367). Mobile: - Connectivity: Refactored connectivity to remove the background signaling task (#364). - EAS Debugging: Enabled the debug menu in preview builds (#360).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes connectivity issues between the FastAPI server and the GSM module within the Docker Compose environment. The GSM gateway is now routed over the internal Docker network rather than defaulting to
localhost, avoiding DNS/routing resolution issues inside containers.Changes
GSM_GATEWAY_URLto explicitly define where the server looks for the GSM module (defaulting tohttp://gsm-fastapi:8001in Compose).SAPOT_API_URLtohttp://api:8000to keep callbacks on Docker's private network instead of routing through nginx.GSM_GATEWAY_URLoverrides are properly picked up by the proxy client.environment-config.mdanddocker-setup.mdwith instructions and explanations regarding internal container networking.