fix: Updated cloud sdk diagram using mermaid#2391
Conversation
davidkna-sap
left a comment
There was a problem hiding this comment.
Apart from my comment, LGTM, but I would prefer an additional review on this.
Co-authored-by: David Knaack <david.knaack@sap.com>
marikaner
left a comment
There was a problem hiding this comment.
Generally, I like this approach, although I am not convinced that it is easier than adjusting pictures...
Anyways. I hate the colors. Can we add this to the themeConfig in the docusaurus.config.js:
mermaid: {
theme: { light: 'neutral', dark: 'dark' }
},
I think this would very much improve looks.
docs-js/overview.mdx
Outdated
| generator -.-> |generates| odataV4Clients | ||
|
|
||
| openapi --> httpClient | ||
| odataV4 --> httpClient |
There was a problem hiding this comment.
[req] Please adjust the names so that they reflect the package names (odata-v2, not odataV2) for all of the packages.
| config: | ||
| layout: elk | ||
| --- | ||
| flowchart TB |
There was a problem hiding this comment.
[q] Is it possible to achieve the same layout as before. Now the arrow goes through one of the boxes, which doesn't look good. Also, the layout before was structured explicitly so that each "line" was a different layer (top generated clients, middle client related layer, bottom core).
[q] Is it possible to change the connectors to be something different than arrows. This isn't really a flow or interitance. Still, arrows are okayish too.
There was a problem hiding this comment.
I have changed it to simple lines instead of arrows.
Unfortunately I don't think that I can put the generators with mermaid on the same level as the odatav2/v4 and openapi (as it was before), without putting them in a subgraph.
I have added it to the config. |
|
I played around with mermaid. It is really difficult to get what I want, however this is the closest I could get with mermaid: ---
config:
---
flowchart TB
subgraph odataClientsGroup["OData Clients"]
odataV2Clients["OData v2 clients"]@{shape: stacked-rectangle}
odataV4Clients["OData v4 clients"]@{shape: stacked-rectangle}
end
subgraph openapiClientsGroup["OpenAPI Clients"]
openapiClients["OpenAPI clients"]@{shape: stacked-rectangle}
end
odataClientsGroup ~~~ generator
openapiClientsGroup ~~~ openapi-generator
openapi-generator -.-> |generates| openapiClientsGroup
generator -.-> |generates| odataClientsGroup
openapi-generator ~~~ http-client
openapi --> http-client
odata-v2 --> http-client
odata-v4 --> http-client
generator ~~~ http-client
openapiClients --> openapi
odataV2Clients --> odata-v2
odataV4Clients --> odata-v4
http-client --> connectivity
Consider this as a starting point. |
Because of the docusaurus configurations, for me it looks slightly different, like this: |
|
btw @BrigittaK307, please take a look at this file: https://github.com/SAP/cloud-sdk/blob/main/static/img/.where-to-get-images.md |
|
|

Closes https://github.com/SAP/ai-sdk-js-backlog/issues/490.
Updated mail client due to deprecation of the mail client.
State before:


Current state: