fix: deserialization bug for Base64Url#1114
Merged
n-o-u-r-h-a-n merged 14 commits intomainfrom Mar 11, 2026
Merged
Conversation
n-o-u-r-h-a-n
changed the title
...v4-core/src/main/java/com/sap/cloud/sdk/datamodel/odatav4/adapter/ODataGenericConverter.java
Outdated
Show resolved
Hide resolved
...a-v4-core/src/test/java/com/sap/cloud/sdk/datamodel/odatav4/core/FieldSerializationTest.java
Show resolved
Hide resolved
...a-v4-core/src/test/java/com/sap/cloud/sdk/datamodel/odatav4/core/FieldSerializationTest.java
Outdated
Show resolved
Hide resolved
Contributor
CharlesDuboisSAP
left a comment
CharlesDuboisSAP
left a comment
There was a problem hiding this comment.
´+//v´ is referenced 3 times and the other one 2 times. It could be great if you put them in a static string with a name. Otherwise lgtm
CharlesDuboisSAP
previously approved these changes
Mar 11, 2026
Contributor
CharlesDuboisSAP
left a comment
CharlesDuboisSAP
left a comment
There was a problem hiding this comment.
A release note would be great
CharlesDuboisSAP
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
odata-v4-core binary deserialization rejects valid Base64URL values for Edm.Binary, so now sdk correctly treats the OutputBinaryData property to be Base64Url-encoded.
Feature scope:
Definition of Done
Error handling created / updated & covered by the tests aboveDocumentation updatedRelease notes updated