Add method to check if a path in zipfs is a symbolic link#2219
Add method to check if a path in zipfs is a symbolic link#2219schmelter-sap wants to merge 2 commits intoSAP:sapmachinefrom
Conversation
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
|
restest this please |
|
Do you really need this SharedSecrets stuff? I think for jdk.nio.zipfs it is fine to add public methods and call them since those are internal implementation classes. You should only need to export the jdk.nio.zipfs package to jdk.sapext and then you can directly call any method you add. |
| * @param path The path in the zipfs. | ||
| * @return <code>true</code> if the path represents a symbolic link. | ||
| */ | ||
| public static boolean isSymbolicLink(Object path) { |
There was a problem hiding this comment.
The parameter should rather be java.nio.file.Path instead of just Object, no?
|
|
||
| return access.isSymbolicLink(path); | ||
| } | ||
| } No newline at end of file |
|
Regarding the shared secrets. A public method in an implementation class for which the user gets access too is still visible. Additionally I don't want to add a module dependency between the ext and the zipfs module, when it is not really needed. |
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
3 participants
This adds a method to check if a given path from zipfs corresponds to a symbolic link.
fixes #2218