Skip to content

Database copy error crash#432

Open
jchu-sandag wants to merge 3 commits into
SANDAG:mainfrom
jchu-sandag:emme_copy_crash
Open

Database copy error crash#432
jchu-sandag wants to merge 3 commits into
SANDAG:mainfrom
jchu-sandag:emme_copy_crash

Conversation

@jchu-sandag

Copy link
Copy Markdown
Contributor

Proposed changes

Edits the copy tool such that the script uses a Windows robocopy in the event that the EMME database cannot be read by the EMME script.

Impact

Recent runs of ABM have all resulted in an error in which the EMME databases could not be read by the EMME script on the remote drive. Thus, the databases could not be copied over from the local drive to the remote drive, forcing users to manually go into the system and close the programs before copying over the rest of the EMME databases. This caused downtime in metrics that required these databases to be within the remote drive. This update will instead initiate a Windows robocopy in the event that the EMME script fails to copy over all the databases to the remove drive.

Types of changes

What types of changes does your code introduce to ABM?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

How has this been tested?

  • Full 2022 scenario run
  • Checks for byte size between both remote and local drive
    • This check has not been checked within a scenario run and has only been checked by manual copy locally

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Further comments

Although not the explicit usage of the following method, the _copy_dir method is a good general copy method for instances where other copying methods fail or run into errors. In the future, an additional update to separate the file masks into file_masks and dir_masks could be beneficial in case any specific directories and files would want to be excluded in a single step. However, this update is not within the scope of this PR and would require further testing.

@cundo92 cundo92 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jchu-sandag thanks for working on and applying this change. I was able to confirm successful copy of a full model run, including the emme_project directory.

@jchu-sandag jchu-sandag marked this pull request as ready for review June 29, 2026 15:45
@jchu-sandag jchu-sandag requested a review from aber-sandag June 29, 2026 15:45
@jchu-sandag jchu-sandag self-assigned this Jun 29, 2026

@aber-sandag aber-sandag left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am somewhat concerned about the effects of overwriting Emme files that are currently in use by Emme. Could you test the following:

  • The file copy output shows that all files were copied successfully when copying emme_project with robocopy? Are there any warnings?
  • After running, when the project is opened from T drive on another server, can Emme matrices and other Emme data be accessed in Emme?

@cundo92

cundo92 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

I am somewhat concerned about the effects of overwriting Emme files that are currently in use by Emme. Could you test the following:

  • The file copy output shows that all files were copied successfully when copying emme_project with robocopy? Are there any warnings?
  • After running, when the project is opened from T drive on another server, can Emme matrices and other Emme data be accessed in Emme?

@jchu-sandag feel free to use my test run at "T:\STORAGE-63T\car_tests\log_test\2022_copyTest" for these follow up comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants