fix(command): publish command results with retain=False#461
Merged
Conversation
Command result topics ("Success" / "Failed: ...") were published with
the default retain=True, so a stale result from a previous run would
persist on the broker and re-appear after a gateway restart. Results
are transient responses — they should not survive a reconnect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Success/Failed: …) were published with the defaultretain=Trueretain=Falseon all threepublish_strcall sites inVehicleCommandHandlerNote
Stale results already present on the broker will persist until overwritten. An explicit clear-on-connect could be added as a follow-up if needed, but requires enumerating all result topic paths.
Test plan
TestVehicleCommandHandlertests updated and passingmypyclean