Minor code hardening and template cleanups#1633
Closed
davmlaw wants to merge 1 commit into
Closed
Conversation
- Generate Django SECRET_KEY with django.core.management.utils.get_random_secret_key() instead of the home-grown random-based generator - Build IconWithTooltip markup with format_html() rather than hand-assembling a SafeString - Use the escapejs filter (not |safe) for values embedded in inline JS string literals in variant_details.html - Cap the length of the free-text MONDO search term forwarded to the external Monarch API - Guard OIDC group removal so a group deleted out-of-band doesn't raise during login
Contributor
Author
|
🤖 Written by Claude Superseded by per-app PRs (one PR per change). Closing this combined PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Written by Claude
A handful of small, self-contained code-quality improvements.
SECRET_KEYwith the standarddjango.core.management.utils.get_random_secret_key()instead of the bespokerandom-basedgenerate_key()helper. Only affects fresh deployments wheredjango_secret_key.txtdoes not yet exist; existing keys are untouched.IconWithTooltip— build the<i>markup withformat_html()instead of hand-assembling aSafeString, removing the manual escaping and dropping now-unused imports.variant_details.html— use theescapejsfilter (instead of|safe) for the two values embedded in inline<script>string literals, so they are always correctly encoded for a JS-string context.search_termforwarded to the external Monarch search API..filter(...).first()so a group deleted out-of-band between logins no longer raises during login.No behaviour change for normal inputs; py_compile clean.