Skip to content

Skip weekly summary email for users with no accessible lab #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davmlaw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Skip weekly summary email for users with no accessible lab #1609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions classification/views/classification_email_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,12 @@ def send_summary_emails():
def send_summary_email_to_user(user: User) -> bool:
discordance_email = settings.DISCORDANCE_EMAIL
if discordance_email:
if not Lab.valid_labs_qs(user=user, admin_check=True).exclude(organization__active=False).exists():
# User has no accessible lab, so there's nothing to summarise - skip rather than raise
report_message("Skipping weekly summary email - user has no accessible lab", level="debug",
extra_data={"user": user.username})
return False

content = summary_email_content(LabPickerData.for_user(user))

return EmailLog.send_mail(subject=content.subject,
Expand Down
Loading