Guard against undefined PanelApp evidence entries (#1597)#1608
Merged
Conversation
The gene grid PanelApp integration iterated over the evidence results list and read confidence_level (via addGeneEvidence and getConfidenceCSS) on each entry. When an entry was undefined, this threw "TypeError: Cannot read properties of undefined (reading 'confidence_level')". Skip falsy entries in the results loop so missing entries are ignored instead of crashing the hover-card rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Skip falsy/undefined entries when iterating the PanelApp gene-evidence results list in
panel_app.js.Why
The gene grid PanelApp integration reads
confidence_levelon each evidence entry (inaddGeneEvidenceandgetConfidenceCSS). When an entry in the results list wasundefined, this threw:The single-line
if (!evidence) continue;guard in the results loop covers both call sites that dereference the entry, so a missing entry is silently skipped instead of crashing the hover-card render.Addresses #1597
Risk
Minimal — only adds a skip for already-broken (undefined) entries; happy-path behaviour is unchanged.
🤖 Generated with Claude Code