Fix None-safe sort in lab-compare export list_of() #1598#1605
Open
davmlaw wants to merge 1 commit into
Open
Conversation
list_of() sorted a set of (value, source) tuples directly. When some records have partial evidence, a source value may be None, and Python raises TypeError comparing str to NoneType during the sort. Provide a sort key that coerces None to empty string, preserving the existing ordering for non-None values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In
classification/views/exports/classification_export_formatter_lab_compare.py,ClassificationLab.list_of()sorts a set of(value, source)tuples directly withsorted(value_set).Why
When records have partial evidence, a
sourcevalue can beNone. Sorting tuples that differ at aNone/strposition raisesTypeError: '<' not supported between instances of 'str' and 'NoneType', breaking the lab-compare export.This change adds a sort key that coerces
Noneto an empty string, so sorting is total. Ordering for non-Nonevalues is unchanged.Addresses #1598
🤖 Generated with Claude Code