refactor: finish cursor → actionId rename in internal libs (#128)

[thedavidmeister]

Summary

Follow-up to #139 finishing the rename in internal libs that were missed. PR #139 covered the public API surface; three internal-lib functions still used `cursor` for data crossing the call boundary, which #128's principle marks as the wrong name.

Renames:

• `LibTotalSupply.onAccountMigrated`: `fromCursor`/`toCursor` → `fromActionId`/`toActionId` (mirrors the `AccountMigrated` event field names)
• `LibRebase.migratedBalance`: `cursor` input → `fromActionId`, `newCursor` return → `toActionId`
• `LibReceiptRebase.migratedBalance`: same shape as `LibRebase`

Stays as cursor (correct per convention):

• `cursor` locals in `StoxReceipt` / `StoxReceiptVault` (walk-position, not data)
• `accountIdCursor` mapping in `LibCorporateActionReceipt` (storage tracking walk progress over time)
• `accountMigrationCursor` / `totalSupplyLatestCursor` in storage

Test plan

• full suite green (497/497 pass)
• static analysis (CI)
• legal (CI)

🤖 Generated with Claude Code

Summary by CodeRabbit

• Refactor
  • Improved internal code organization and naming conventions for better maintainability. No functional changes or end-user impact.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4bc482ae-eb5f-4b5d-a131-fce82a9969ea

📥 Commits

Reviewing files that changed from the base of the PR and between 3fb2345 and 5cecc3a.

📒 Files selected for processing (3)

• src/lib/LibRebase.sol
• src/lib/LibReceiptRebase.sol
• src/lib/LibTotalSupply.sol

---

📝 Walkthrough

Walkthrough

Three related library functions (LibRebase.migratedBalance, LibReceiptRebase.migratedBalance, and LibTotalSupply.onAccountMigrated) undergo coordinated parameter and return value renaming from cursor/newCursor terminology to fromActionId/toActionId. Control flow and logic remain unchanged; only naming and supporting NatSpec documentation are updated.

Changes

Migration Position Tracking API Renaming

Layer / File(s)	Summary
Core Function Signatures src/lib/LibRebase.sol, src/lib/LibReceiptRebase.sol, src/lib/LibTotalSupply.sol	Parameters renamed: cursor → fromActionId, newCursor/toCursor → toActionId. Return types and tuple structures remain identical. All three functions now use consistent migration-position naming.
NatSpec Documentation src/lib/LibRebase.sol, src/lib/LibReceiptRebase.sol, src/lib/LibTotalSupply.sol	Documentation updated to reflect fromActionId and toActionId semantics. Loop initialization and traversal logic descriptions updated to align with renamed variables; balance migration accounting logic unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

• Review LibRebase.migratedBalance optimization choices #84: Directly involves LibRebase.migratedBalance renaming for semantic clarity on parameter scope from cursor position tracking.

Possibly related PRs

• fix: replace null-pointer ambiguity with init-as-node bootstrap (#79) #124: Touches the same three migration functions with aligned cursor/node semantics and BALANCE_MIGRATION_TYPES_MASK logic.
• feat: doubly linked list and action lifecycle #22: Introduces the corporate-action linked-list traversal API (LibCorporateActionNode.nextOfType) and accountMigrationCursor storage that these renames semantically clarify.
• feat: rebase-aware totalSupply with per-cursor pots #24: Uses the same migration-cursor APIs in migratedBalance and LibTotalSupply.onAccountMigrated that are being renamed for consistency.

Poem

🐰 ✨
From cursor to fromActionId we trace,
Where migrations hop through action space,
To toActionId they jump and land—
A semantic leap that readers understand!
🪃

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: finishing the cursor → actionId rename across internal library functions (LibRebase, LibReceiptRebase, LibTotalSupply).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/issue-128-finish-cursor-to-id-rename

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 0/1 reviews remaining, refill in 60 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}