Fix date comparison error and add disbursement transaction support#2
Open
thebruge wants to merge 1 commit intoRyderpro:mainfrom
Open
Fix date comparison error and add disbursement transaction support#2thebruge wants to merge 1 commit intoRyderpro:mainfrom
thebruge wants to merge 1 commit intoRyderpro:mainfrom
Conversation
This commit addresses two issues in the Venmo history export script:
1. Fixed date comparison error (line 203-204):
- Added type check before date comparison to handle cases where
hash[:date_completed] might already be a Date object
- Prevents comparison errors by parsing only when needed
2. Added support for disbursement transaction type (lines 181-189):
- Added new 'when "disbursement"' case handler
- Maps disbursement events to transaction format with proper fields:
date_completed, description, amount, and merchant display_name
- Prevents disbursements from falling through to unknown event handler
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses two issues in the Venmo history export script:
1. Fixed date comparison error (line 203-204)
hash[:date_completed]might already be a Date object2. Added support for disbursement transaction type (lines 181-189)
when "disbursement"case handler to properly process disbursement eventsdate_completed: parsed fromevent['date_created']description: transaction type (DISBURSEMENT)amount: fromevent['disbursement']['amount']name: merchant display name fromevent['disbursement']['merchant']['display_name']Test Plan
🤖 Generated with Claude Code