Win: always link with opengl32.lib #217
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winapi explicitly doesn't link with opengl32.lib on all supported Windows platforms (aarch64 and thumbv7a). Presumably this dates back to when these Windows platforms didn't support OpenGL. Since that's no longer the case, and baseview won't be able to link successfully if the opengl feature is enabled and opengl32.lib isn't linked, this change makes it explicitly link opengl32.lib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
winapi explicitly doesn't link with opengl32.lib on all supported Windows platforms (aarch64 and thumbv7a). Presumably this dates back to when these Windows platforms didn't support OpenGL. Since that's no longer the case, and baseview won't be able to link successfully if the opengl feature is enabled and opengl32.lib isn't linked, this change makes it explicitly link opengl32.lib.