Repository navigation
release: fix draft asset path; firmware builder tools - #66
Merged
Merged
Conversation
sd-fuse runs `sudo apt install` for simg2img, swig, sfdisk and mkfs.btrfs when they are missing, which fails in the container (no apt lists). Bake them into the image instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
build-uboot.sh falls back to `sudo apt install python2-dev` when Python.h is missing, which does not exist on jammy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The draft job downloaded into assets/, which the checkout already has (assets/images), so `sha256sum *` hit a directory and the first v0.1.0 run failed before creating the draft. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by 4c
Summary
Before: the first Release run for 0.1.0 built the application but failed before creating the draft (
sha256sum: images: Is a directory), and the firmware build stopped at u-boot because the SDK scripts tried toapt installmissing tools inside the container.After: the draft job downloads the build artifact into
release-assets/and the firmware builder image ships the tools the SDK scripts expect, so both runs can complete.How
release.yml: the artifact was downloaded intoassets/, which the checkout already contains (assets/images); nowrelease-assets/.ci/firmware/Dockerfile: preinstallandroid-sdk-libsparse-utils(simg2img),swig,fdisk,btrfs-progs,python3-dev,python3-pyelftools. sd-fuse'scheck_and_install_packageandbuild-uboot.shotherwise runsudo apt installwithout apt lists.Testing
Downloaded the failed run's artifact: it holds only the 4 expected files, confirming the directory came from the repo's
assets/.Firmware build with the new image gets past u-boot (
Building uboot ok!) and is building the kernel.No Rust changes.
cargo +nightly fmt --allcargo +nightly clippy --workspace --release --all-targets -- -D warningscargo +nightly test --workspaceFrontend touched:
trunk build --lockedand wasm32 clippy incrates/rkvm-web. Not applicable.Tested on an RK3588 device (describe below), or not applicable. Not applicable.
Checklist
#[allow(...)]suppressions and no newunwrap()/expect()in production pathsMissedTickBehavior::Delayrkvm-protoapp/tests/rpc_methods.txtupdatedAGENTS.mdupdated🤖 Generated with Claude Code