[Rust-KVM]

Requested by 4c

Summary

Before: only the reference WSL workbench could build RustKVM. The device binary needed a self-built stage2 rustc and /opt/rk3588-buildkit, and the firmware came from a FriendlyElec SDK checkout whose RustKVM changes were uncommitted local edits in five projects (one of them a local branch).

After: any x86_64 Linux host with Docker builds the application package with scripts/devkit.sh run scripts/build-app.sh and the SD / eMMC-flasher firmware images with scripts/devkit.sh firmware. Every toolchain and SDK commit is pinned in the repository, and every SDK change lives here as a patch.

How

• ci/devkit/Dockerfile: the RK3588 buildkit image plus nightly-2026-06-14 (device binary, -Z build-std), 1.96.0 (frontend) and Trunk 0.21.14. RUSTUP_TOOLCHAIN overrides the stage2 rust-toolchain.toml, so nobody else has to build rustc. .devcontainer/ uses the same image.
• ci/firmware/Dockerfile: Ubuntu 22.04 host for the FriendlyElec SDK with a sha256-pinned repo launcher; runs --privileged for loop devices.
• ci/buildkit/Dockerfile: now takes the Buildroot host dir as the rk3588-buildkit named context, so it can be built from /opt/rk3588-buildkit or a firmware build without copying into the repo. buildkit.yml passes the context.
• os/rk3588/: manifest.xml pins all 14 SDK projects to upstream commits on github.com/friendlyarm; patches/ holds the buildroot, kernel, sd-fuse, external and device changes exported from the workbench (checked to apply cleanly to the pinned commits); rootfs-overlay/ is the former device/friendlyelec/rustkvm-files.
• scripts/build-firmware.sh steps sync → patch → build → collect produce out/firmware/rustkvm-rk3588-<app>-<date>-<rev>-{sd,eflasher}.img.gz, /etc/rustkvm-release and SHA256SUMS.
• S99rustkvm stop/restart used killall -9, which skips the watchdog disarm and reboots the board. It now sends SIGTERM and waits.
• The vendor root password is no longer written by our defconfig patch. RUSTKVM_ROOT_PASSWORD (a crypt hash, outside the repo) sets it at build time; otherwise root password login is disabled. SSH was already key-only (dropbear -s, devmode only).
• release.yml pins the same nightly as the devkit.
• Separate commit: zip 8 → 9 and rustls 0.23.46 in the lockfile, because new RustSec advisories (RUSTSEC-2026-0346..0349, 0367..0369) made cargo deny fail on dev. zip is only used through ZipWriter, whose API did not change.
• Docs: docs/building.md, docs/firmware-release.md (versions, release checklist, flashing, factory state, acceptance test), os/rk3588/README.md, AGENTS.md and README updated.

Look closely at: the firmware build has not been run end to end from this tree yet (first run is a ~15 GB sync and several hours), and the RUSTKVM_ROOT_PASSWORD default changes serial-console login on newly built images.

Testing

• scripts/devkit.sh image then scripts/devkit.sh run scripts/build-app.sh on the workbench: Trunk build + aarch64 release binary in 6m19s, rustc 1.98.0-nightly (1f087276b 2026-06-13), output is an aarch64 ELF.

• scripts/devkit.sh firmware-image builds; repo 2.69 and passwordless sudo verified in the container.

• Every patch in os/rk3588/patches applies with git apply to its pinned commit (checked against a temporary index of the workbench SDK).

• repo init --depth=1 + repo sync -c -d against a pinned non-tip commit checks out the exact commit (tested with buildroot_device_friendlyelec).

• fmt, host clippy -D warnings and cargo test --workspace pass inside the devkit container (so the devkit doubles as the local quality gate); cargo deny check passes.

• cargo +nightly fmt --all

• cargo +nightly clippy --workspace --release --all-targets -- -D warnings

• cargo +nightly test --workspace

• Frontend touched: trunk build --locked and wasm32 clippy in crates/rkvm-web (not touched; trunk build --release --locked ran in the devkit)

• Tested on an RK3588 device (describe below), or not applicable — not applicable, nothing was flashed or deployed

Checklist

• No #[allow(...)] suppressions and no new unwrap() / expect() in production paths
• Hot paths stay zero-copy; periodic loops use MissedTickBehavior::Delay
• Shared protocol types live in rkvm-proto
• RPC method set changed → app/tests/rpc_methods.txt updated
• Module tree or build invariants changed → AGENTS.md updated

🤖 Generated with Claude Code