Repository navigation
webrtc: negotiate H.264 High profile when the browser offers it - #62
Merged
Merged
Conversation
mpph264enc emits High profile (level 5.2, 640034), but only a Constrained Baseline codec was registered, so the answer always labelled the stream 42e01f. Chrome tolerates the mismatch; stricter decoders may not. Register a High profile H.264 codec alongside the existing Constrained Baseline one and give the video track the High fmtp, so binding picks the negotiated High payload when the offer has one (Chrome, Safari, Edge) and otherwise falls back to the first negotiated H.264 payload as before. This assumes the default encoder profile; a --video-profile override is not reflected in the SDP. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by 4c · project thread
Summary
Before: mpph264enc emits High profile (level 5.2,
640034), but only a Constrained Baseline H.264 codec was registered, so the SDP answer always labelled the stream42e01f. Chrome tolerates the mismatch; stricter decoders may not.After: when the browser offers H.264 High (Chrome, Safari, Edge), the answer negotiates High and the SDP matches what the encoder sends. Offers without High fall back to the existing Constrained Baseline entry as before.
How
webrtc.rs: register a second H.264 codec (payload 106,profile-level-id=640034) next to the Constrained Baseline one, and give the video track the High fmtp so binding prefers the negotiated High payload. This assumes the default encoder profile; a--video-profileoverride is not reflected in the SDP.Testing
cargo +nightly fmt --all(CI)cargo +nightly clippy --workspace --release --all-targets -- -D warnings(CI)cargo +nightly test --workspace(CI)Checklist
#[allow(...)]suppressions and no newunwrap()/expect()in production pathsMissedTickBehavior::Delayrkvm-protoPart of a set of three video PRs (#60, #61); merges onto
devtogether with them without conflicts.🤖 Generated with Claude Code
https://claude.ai/code/session_01PbdzY6PfT28goR4BhqdsXR
Generated by Claude Code