Skip to content

webrtc: release taken-over sessions' UDP sockets #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rust-KVM merged 1 commit into from
Oct 11, 2026
Merged

webrtc: release taken-over sessions' UDP sockets #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/src/webrtc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,12 @@ impl WebRTCApi {
})
}));

let session_clone = session.clone();
// This handler (and the data channel callbacks it installs) lives inside
// the peer connection, so it must not hold the connection itself: that
// cycle kept every closed session's ICE agent alive, and with it one
// UDP socket per local address, because UDP conns only close on drop.
let mut session_clone = session.clone();
session_clone.peer_connection = None;
peer_connection.on_data_channel(Box::new(move |data_channel: Arc<RTCDataChannel>| {
let session = session_clone.clone();
let label = data_channel.label().to_string();
Expand Down
Loading