Repository navigation
web: 404 unknown paths instead of serving index.html - #49
Merged
Merged
Conversation
The embedded frontend was served with index.html as a catch-all, so /favicon.ico, /logs or any typo returned 200 text/html. The frontend has no client-side routes, so serve index.html only for / and let other misses 404. Add an inline SVG favicon so browsers stop requesting /favicon.ico. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
area: api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by 4c · project thread
Summary
Before: any unknown path, including
/favicon.ico, returnedindex.htmlwith 200, so typos and probes looked like valid pages and the browser got HTML as its favicon.After: only
/serves the app; unknown paths return 404. The page carries an inline SVG favicon so browsers stop asking for/favicon.ico.How
routes.rs: the static embed handler uses.defaults("index.html")(directory index only) instead of.fallback("index.html"). The frontend has no client-side routes, so nothing relied on the fallback.index.htmlgets adata:SVG<link rel="icon">.Testing
cargo +nightly fmt --all(CI)cargo +nightly clippy --workspace --release --all-targets -- -D warnings(CI)cargo +nightly test --workspace(CI)trunk build --lockedand wasm32 clippy incrates/rkvm-web(CI)/returns 200, unknown paths return 404, startup log has no WARN/ERROR.Checklist
#[allow(...)]suppressions and no newunwrap()/expect()in production pathsMissedTickBehavior::Delayrkvm-protoRound 2 of the web UI retest fixes (minor issues). The five round-2 branches merge onto
devtogether without conflicts.🤖 Generated with Claude Code
https://claude.ai/code/session_01PbdzY6PfT28goR4BhqdsXR
Generated by Claude Code