Repository navigation
webui: settings polish (update gating, password confirm, video sleep, real time zone) - #48
Merged
Merged
Conversation
- Update now stays disabled until Check reports an update. - Setting or changing the password asks for the new one twice. - Video sleep shows -1 when the device reports it disabled (the device keeps the last duration while off). - Timezone shows the device's actual zone via a new read-only getTimezone RPC (TZ, /etc/timezone, /etc/localtime, else UTC). There is no setter yet, so the select is disabled and says so. - The macro steps placeholder showed a literal ; use a newline. - Mount URL with an empty field now says to enter a URL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by 4c · project thread
Summary
Before: "Update now" could be pressed without any update found; the password was entered once with no confirmation; Video sleep showed the stored duration even when sleep was disabled; the Timezone dropdown looked editable but did nothing and did not show the device's zone; the macro placeholder showed a literal
; Mount with an empty URL did nothing.After:
How
getTimezone(TZ, then/etc/timezone, then the/etc/localtimesymlink target, elseUTC), registered inregistry_builder.rsand added toapp/tests/rpc_methods.txt.settings.rs:update_availableandconfirm_pwsignals; video sleep readsenabled; mount URL trimmed and validated.settings_advanced.rs: loadsgetTimezone, inserts it into the list if missing, disables the select.Testing
cargo +nightly fmt --all(CI)cargo +nightly clippy --workspace --release --all-targets -- -D warnings(CI)cargo +nightly test --workspace(CI; covers the RPC method list)trunk build --lockedand wasm32 clippy incrates/rkvm-web(CI)getTimezonereturnsUTC, 4K60 video plays, startup log has no WARN/ERROR.Checklist
#[allow(...)]suppressions and no newunwrap()/expect()in production pathsMissedTickBehavior::Delayrkvm-protoapp/tests/rpc_methods.txtupdatedRound 2 of the web UI retest fixes (minor issues). The five round-2 branches merge onto
devtogether without conflicts.🤖 Generated with Claude Code
https://claude.ai/code/session_01PbdzY6PfT28goR4BhqdsXR
Generated by Claude Code