Repository navigation
webui: fix settings that showed wrong or empty values - #45
Merged
Merged
Conversation
- Keyboard layout: option values were en_US/de_DE/..., but the device reports and accepts us/uk/de/..., so the select was blank and any change was rejected. Use the device codes (and add Korean). - Power: the DC section read supported/enabled fields the device never sends, so it always said "not supported"; ATX state was requested even when ATX is not mounted, which logged an ERROR on every open and left the buttons live. Show DC or ATX controls by the active extension, read isOn/restoreState and the V/A/W reading, and hint when neither extension is active. - Mouse: switching to relative mode now checks that the relative mouse USB function is enabled and says how to enable it instead of silently sending reports the host never receives. - Network: show gateway and DNS, and note when the page was loaded via a different address than the one reported (the device has two NICs). - About: omit the empty system version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by 4c · project thread
Summary
Before: several settings showed wrong or empty values. The keyboard layout dropdown used codes like
en_USthat the device does not recognise, so the current layout never showed and changes failed. The Power section always said "DC power not supported" and requested ATX state even with no ATX extension, which logged an ERROR on the device. Switching to relative mouse with that USB function disabled silently sent nothing. Network showed only the IP, and Version showed an empty "system" field.After: the layout list uses the device's own codes (
us,uk,de,fr,es,it,jp,kr). Power shows DC controls with live V/A/W readings only when dc-power is active, ATX buttons and LED state only when atx-power is active, and a hint when neither is. Relative mouse refuses to switch, with a message pointing to Settings → USB devices, when that function is off. Network shows gateway, DNS, and notes when the page was opened via a different interface address. Version shows only "app …" when the system version is empty.How
settings.rs: new layout codes;describe_network()used for both the initial load and DHCP renew; version string skips an empty system version.settings_advanced.rs: callsgetActiveExtensionfirst and only queriesgetDCPowerState(readingisOn/restoreState/voltage/current/power) orgetATXStatefor the mounted extension.app.rs:toggle_mousechecksgetUsbDevices().relative_mousebefore enabling relative mode.Testing
cargo +nightly fmt --all(CI)cargo +nightly clippy --workspace --release --all-targets -- -D warnings(CI)cargo +nightly test --workspace(CI)trunk build --lockedand wasm32 clippy incrates/rkvm-web(CI)Checklist
#[allow(...)]suppressions and no newunwrap()/expect()in production pathsMissedTickBehavior::Delay(frontend only)rkvm-protoPart of the old-version web UI test report fixes. The four branches touch overlapping files but merge onto
devtogether without conflicts.🤖 Generated with Claude Code
https://claude.ai/code/session_01PbdzY6PfT28goR4BhqdsXR
Generated by Claude Code