Skip to content

Suggested github action change, to prevent clutter in draft PRs #2940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
morrowcj wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Suggested github action change, to prevent clutter in draft PRs #2940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
23dd832
don't waste GH resources on draft PR
morrowcj Apr 8, 2026
402117e
add job dependence on draft job
morrowcj Apr 8, 2026
5572d39
switched 'needs' for 'if'
morrowcj Apr 8, 2026
a3a98eb
add converted_to_draft trigger
morrowcj Apr 8, 2026
3a40987
added changes to changelog
morrowcj Apr 8, 2026
4a0c9ce
re-enable manual job exec.
morrowcj Apr 10, 2026
0976cd2
remove failing check - just skip on draft
morrowcj Apr 14, 2026
af4da69
Merge branch 'dev' into no-draft-actions
morrowcj Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/combined_format_lint_test_mypy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,16 @@ on:
branches: [ dev ]
pull_request:
branches: [ dev ]
types: [opened, synchronize, reopened, ready_for_review, converted_to_draft]
Copy link
Copy Markdown
Collaborator

@ew3361zh ew3361zh Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you talk a little about how you put together this particular group of types (and maybe what synchronize is?)?

Copy link
Copy Markdown
Collaborator Author

@morrowcj morrowcj Apr 14, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great question: the defaults (if you don't include the "types" key) that trigger an action on PR are opened, synchronize, and reopen. I wanted to also add triggers for converting the PR to and from drafts. Source

I believe synchronize is whenever there is a commit pushed to the HEAD reference of the PR's "from" branch.

workflow_dispatch:

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

jobs:
format_code:
name: Format Code
if: ${{ github.event.action == 'workflow_dispatch' || github.event.pull_request.draft == false }}
runs-on: ubuntu-latest
outputs:
changelog_updated: ${{ steps.record_if_changelog_updated.outputs.is_changelog_updated }}
Expand Down Expand Up @@ -168,6 +171,7 @@ jobs:

lint_test_type_check:
name: Lint, Test, Coverage, and Type Checking
if: ${{ github.event.action == 'workflow_dispatch' || github.event.pull_request.draft == false }}
needs: format_code
runs-on: ubuntu-latest
steps:
Expand Down
2 changes: 2 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ v1.0.0
- [2949](https://github.com/RuminantFarmSystems/RuFaS/pull/2949) - [minor change] [NoInputChange] [NoOutputChange] [Verbosity] Updates CLI verbosity arg to override verbosity of full run including task manager verbosity.
- [2947](https://github.com/RuminantFarmSystems/RuFaS/pull/2947) - [minor change] [NoInputChange] [NoOutputChange] [Animal][Reproduction] Created weather data cross validation rules.
- [2948](https://github.com/RuminantFarmSystems/RuFaS/pull/2948) - [minor change] [Feeds][NoInputChange] [NoOutputChange] Removes feed id maximums in metadata properties.
- [2940](https://github.com/RuminantFarmSystems/RuFaS/pull/2940) - [minor change] [NoInputChange] [NoOutputChange] update github actions to hold automated checks until the PR is no longer a draft.


### v1.0.0

Expand Down
Loading