[SimulationEngine] Disentangle module data sharing in SimulationEngine#2939
[SimulationEngine] Disentangle module data sharing in SimulationEngine#2939
Conversation
|
Current Coverage: % Mypy errors on sim-eng-data-disentanglement branch: 1274 |
|
🚨 Please update the changelog. This PR cannot be merged until |
|
Current Coverage: % Mypy errors on sim-eng-data-disentanglement branch: 1218 |
|
🚨 Please update the changelog. This PR cannot be merged until |
|
Current Coverage: % Mypy errors on sim-eng-data-disentanglement branch: 1218 |
|
🚨 Please update the changelog. This PR cannot be merged until |
Context
Issue(s) closed by this pull request: closes #2855 closes #2858
What
SimulationTypeproperties to group simulation types by which modules are neededSimulationEngine.initialize_simulation()to only initialize necessary modules based on theseSimulationTypeproperty groupingsTODOs remaining:
FIELDS_AND_FEEDSsimulation type runscrops_to_get_next_harvest_dates(needsFeedManager) inSimulationEngine._build_harvest_schedule()(aFieldManageroperation)FeedManagerinSimulationEngine._execute_daily_field_operations()(aFieldManageroperation)SimulationEngine._initialize_simulation()Why
This is a key set of steps necessary to be able to isolate each RuFaS biophysical module and allow them all to run individually.
How
See
Whatsection andFiles changedtab for now.Test plan
So far have just run
example_freestallandexample_field_and_feedtasks on this branch but both seem successful.Input Changes
Output Changes
Filter