[Cross Validation] Added cross validation rules for the SC module

RUFAS/data_validator.py

@@ -1709,7 +1709,6 @@ def extract_value_by_key_list(
         >>> DataValidator.extract_value_by_key_list(example_data, var_path)
         'straw'
         """
-
         for key in variable_path:
             if isinstance(data, list) and 0 <= int(key) < len(data):
                 data = data[int(key)]
@@ -1748,6 +1747,9 @@ def __init__(self) -> None:
             "is_of_type": lambda left, right, eager_termination: self._evaluate_is_type(left, right, eager_termination),
             "is_null": lambda left, _right, _eager_termination: self._evaluate_is_null(left),
             "regex": lambda left, right, _eager_termination: self._evaluate_regex(left, right),
+            "is_equal_length": lambda left, right, _eager_termination: self._evaluate_equal_data_length(
+                left, right, _eager_termination
+            ),
         }
 
     def cross_validate_data(
@@ -2170,6 +2172,25 @@ def _validate_relationship(self, relationship: Any, eager_termination: bool) ->
         else:
             return True
 
+    def _evaluate_equal_data_length(self, left_hand_value: Any, right_hand_value: Any, eager_termination: bool) -> bool:
+        """Evaluates if data lengths matches."""
+        if not (isinstance(left_hand_value, list) and isinstance(right_hand_value, list)):
+            self._event_logs.append(
+                {
+                    "error": "Invalid data length validation",
+                    "message": "Both data have to be list type to validate their length.",
+                    "info_map": {
+                        "class": self.__class__.__name__,
+                        "function": self._evaluate_equal_data_length.__name__,
+                    },
+                }
+            )
+            if eager_termination:
+                raise ValueError("Cross-validation error: Invalid type comparison.")
+            return False
+        else:
+            return len(left_hand_value) == len(right_hand_value)
+
     def _evaluate_equal_condition(self, left_hand_value: Any, right_hand_value: Any) -> bool:
         """Evaluates equal condition."""
         return bool(left_hand_value == right_hand_value)
@@ -2184,7 +2205,6 @@ def _evaluate_is_null(self, left_hand_value: Any) -> bool:
 
     def _evaluate_is_type(self, left_hand_value: Any, data_type: Any, eager_termination: bool) -> bool:
         """Evaluates the if_type condition"""
-        # TODO: Remove these type checks when cross validation inputs' validation is implemented - issue #2615
         if not isinstance(data_type[0], str):
             self._event_logs.append(
                 {

changelog.md

@@ -60,10 +60,10 @@ v1.0.0
 - [2921](https://github.com/RuminantFarmSystems/RuFaS/pull/2921) - [minor change] [OutputManager][NoInputChange] [NoOutputChange] Override incorrect fill type for complex data structure data padding.
 - [2924](https://github.com/RuminantFarmSystems/RuFaS/pull/2924) - [minor change] [NoInputChange] [NoOutputChange] Updated advance purchase allowance to prevent excessive warnings for example run.
 - [2929](https://github.com/RuminantFarmSystems/RuFaS/pull/2929) - [minor change] [GraphGenerator] [NoInputChange] [NoOutputChange] Sanitizes non-numerical data sent to graph generator to allow graphing to occur despite.
+- [2916](https://github.com/RuminantFarmSystems/RuFaS/pull/2916) - [minor change] [Corss Validation] [NoInputChange] [NoOutputChange] Added cross validation rules for the Crop and Soil module.
 - [2925](https://github.com/RuminantFarmSystems/RuFaS/pull/2925) - [minor change] [NoInputChange] [NoOutputChange] Fix the `graph_and_report` option in report_generation.py.
 - [2907](https://github.com/RuminantFarmSystems/RuFaS/pull/2907) - [minor change] [NoInputChange] [OutputChange] Fix the FarmGrownFeed Emissions unit issue. The mirror issue of [Fix FarmGrownFeed Emissions Unit on test #2908](https://github.com/RuminantFarmSystems/MASM/pull/2908) to update `dev`.
 
-
 ### v1.0.0
 
 - [2081](https://github.com/RuminantFarmSystems/RuFaS/pull/2081) - [minor change] [Crop & Soil] Break down the `_setup_field()` function in `FieldManager`.

input/data/crop/example_alf_corn_silage_rotation.json

@@ -1,6 +1,6 @@
 {"crop_schedules":
   [
- 
+
   {
     "crop_species": "corn_silage",
     "planting_days": [