Skip to content

[Scientific Documentation] - Update to rufas.bib #2897

Open
gmg228 wants to merge 9 commits intodevfrom
upd_animal_gg0325
Open

[Scientific Documentation] - Update to rufas.bib #2897
gmg228 wants to merge 9 commits intodevfrom
upd_animal_gg0325

Conversation

@gmg228
Copy link
Copy Markdown
Contributor

@gmg228 gmg228 commented Mar 25, 2026

Context

Issue(s) closed by this pull request: closes #2878

  1. Aim to close the Issue linked above.

What

  1. The requested reference was already present, but the in text citation was incorrectly tagged. This has been fixed to appear by AN.MET.6 by updating to /parencite

Why

  1. It is important that all documentation is properly cited for user clarity on methods and updates as they occur.

How

  1. By changing the animal.tex file L6088 from /nocite to /cite ensures that the citation appears next to the appropriate equation.

Test plan

  1. Changes have been previewed in the main.pdf document in this branch.

Input Changes

  1. No input modifications are required.

Output Changes

  • N/A

Filter

  • N/A

@github-actions
Copy link
Copy Markdown
Contributor

Current Coverage: 99%

Mypy errors on upd_animal_gg0325 branch: 1212
Mypy errors on dev branch: 1212
No difference in error counts

@github-actions
Copy link
Copy Markdown
Contributor

🚨 Please update the changelog. This PR cannot be merged until changelog.md is updated.

@github-actions
Copy link
Copy Markdown
Contributor

Current Coverage: 99%

Mypy errors on upd_animal_gg0325 branch: 1212
Mypy errors on dev branch: 1212
No difference in error counts

@github-actions
Copy link
Copy Markdown
Contributor

🚨 Please update the changelog. This PR cannot be merged until changelog.md is updated.

@gmg228 gmg228 requested a review from KFosterReed March 26, 2026 16:12
@github-actions
Copy link
Copy Markdown
Contributor

Current Coverage: 99%

Mypy errors on upd_animal_gg0325 branch: 1212
Mypy errors on dev branch: 1212
No difference in error counts

@github-actions
Copy link
Copy Markdown
Contributor

🚨 Please update the changelog. This PR cannot be merged until changelog.md is updated.

@github-actions
Copy link
Copy Markdown
Contributor

Current Coverage: 99%

Mypy errors on upd_animal_gg0325 branch: 1212
Mypy errors on dev branch: 1212
No difference in error counts

@gmg228 gmg228 changed the title [Scientific Documentation] - Update to rufas.bib and Workflow Guideline Review [Scientific Documentation] - Update to rufas.bib Mar 26, 2026
Comment thread input/task_manager_metadata.json Outdated
Comment thread input/data/tasks/evalfarm_test.json Outdated
"metadata_file_path": "input/metadata/farm1_wcrops_metadata.json",
"output_prefix": "d1farm_mcr0.8",
"log_verbosity": "errors",
"root_input": "C:/Users/gmg228/Documents/RuFaS/RuFaS-Evaluation/",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is specific to your computer

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct. I think I fixed that!

Comment thread input/data/tasks/evalfarm_test.json Outdated
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional to add this new task to the main RuFaS repo?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not.
Thank you for catching. I think it has been resolved.

gmg228 and others added 3 commits March 30, 2026 13:45
@github-actions
Copy link
Copy Markdown
Contributor

Current Coverage: 99%

Mypy errors on upd_animal_gg0325 branch: 1195
Mypy errors on dev branch: 1195
No difference in error counts

@gmg228 gmg228 requested a review from allisterakun March 31, 2026 12:55
Copy link
Copy Markdown
Collaborator

@allisterakun allisterakun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Scientific Documentation] Add reference for Mutian Niu Methane mdoel

2 participants