Conversation
github-actions
bot
force-pushed
the
reset_daily_stats-reordering
branch
from
b938fa8 to
1ce6055
Compare
…inantFarmSystems/RuFaS into reset_daily_stats-reordering
|
Current Coverage: 99% Mypy errors on reset_daily_stats-reordering branch: 1688 |
|
Current Coverage: 99% Mypy errors on reset_daily_stats-reordering branch: 1683 |
krb78
left a comment
krb78
left a comment
There was a problem hiding this comment.
the order looks good to me!
YijingGong
left a comment
YijingGong
left a comment
There was a problem hiding this comment.
LGTM. Left one comment - think it's a typo.
| num_cow_for_parity: dict[str, int] | ||
| avg_daily_cow_milking = 0.0 | ||
|
|
||
| stillborn_calf_info: list[StillbornCalfTypedDict] |
There was a problem hiding this comment.
I see it here. So I guess in the above docstring, it should be StillbornCalfTypedDict
matthew7838
left a comment
matthew7838
left a comment
There was a problem hiding this comment.
LGTM, thanks for cleaning this up, Joe.
|
Current Coverage: 99% Mypy errors on reset_daily_stats-reordering branch: 1423 |
|
Current Coverage: 99% Mypy errors on reset_daily_stats-reordering branch: 1423 |
4 participants
Context
Issue(s) closed by this pull request: closes #1215
What
Reordered some of the
reset_daily_statsmethod to make it easier to find related attributes. Also reviewed need to reset these on a daily basis.Also adds some missing docstrings.
Also removed an entirely unused attribute.
Why
Fixathon 2026!
How
Test plan
No unit tests affected for reordering, removed check in existing unit test for deprecated attribute.