Repository navigation
Bump image_processing from 1.14.0 to 2.2.0 and add ruby-vips - #39
Merged
Merged
Conversation
image_processing 2.0 made mini_magick and ruby-vips soft dependencies, so the plain Dependabot bump (#32) silently dropped ruby-vips. Active Storage uses the vips processor/analyzer by default, so add ruby-vips explicitly to keep treasure_image analysis and any variants working. mini_magick stays dropped since nothing uses it. Supersedes #32. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UZdu9KhK3eVCqk8Tdwm6tA
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UZdu9KhK3eVCqk8Tdwm6tA
A bare `gem "ruby-vips"` is loaded by Bundler.require at boot, which crashes when libvips is not installed (CI scan_js job). Active Storage already requires ruby-vips itself behind a LoadError rescue, so `require: false` restores the previous behaviour of image_processing 1.x, where ruby-vips was only a transitive dependency. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UZdu9KhK3eVCqk8Tdwm6tA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #32.
Why not merge #32 as-is
image_processing 2.0 made
mini_magickandruby-vipssoft dependencies that you must add to your Gemfile yourself. The plain Dependabot bump therefore removedruby-vipsfrom the bundle. Active Storage uses vips by default for both variants and image analysis. Without the gem,Hunt#treasure_imageuploads would quietly skip analysis (no width/height metadata), and any future.variantcall would raise. CI stayed green only because no test exercises that path.Changes
image_processing~> 1.2→~> 2.2gem "ruby-vips", require: false(libvips is already installed in the Dockerfile and CI test jobs)require: falsematters. Active Storage itself doesrequire "ruby-vips"behind arescue LoadError. A bare gem would be loaded byBundler.requireoutside that rescue, so the app would fail to boot wherever libvips is missing (e.g. thescan_jsCI job, which is what failed on the first commit).mini_magickstays dropped, since nothing uses it.claude/docs/log.md: log entry for this Dependabot batchVerification (local, Ruby 3.4.11)
bin/rails test: 419 runs, 0 failures, 0 errorsbin/rubocop: no offensesImageProcessing::Vipsresize works, andActiveStorage::Analyzer::ImageAnalyzer::Vipsaccepts image blobsCould not open library 'vips.so.42'boot crash. Withrequire: false,bin/importmap auditpasses and Active Storage reportsVIPS_AVAILABLE=false, the same as onmain🤖 Generated with Claude Code
https://claude.ai/code/session_01UZdu9KhK3eVCqk8Tdwm6tA