Repository navigation
fix: Apply, gao --apply and the watchdog refuse a second NVIDIA GPU too - #74
Merged
Merged
Conversation
Runs and the logon apply already refused a PC with more than one NVIDIA GPU. The window's Apply saved tune and gao --apply now pass NVML's count to decide_boot through saved_tune_for, and the tray watchdog does not put a tune back once a second NVIDIA GPU is counted: it writes the refusal to boot.log and shows the short balloon once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#65 made runs and the logon apply refuse a PC with more than one NVIDIA GPU, and listed three places that did not: the window's Apply saved tune,
gao --applyand the tray watchdog's re-apply. They write a saved tune without testing it, so with two cards they could write it to a card it was not made for.What
saved_tune_for(driver, gpu_id, nvidia_gpus, refusal): the count goes todecide_boot, which returnsSeveralGpusfirst. Callers: the Apply button andgao --applypassNvml::DeviceCount(); the undervolt on the saved tune passes 1, because its run already refused before it began.gpu_okfalse). The tune is not put back; the refusal goes to boot.log and the short balloon (kSeveralGpusBalloon) is shown once.docs/development.md: the "not refused yet" part of the design-decision row now says what refuses.An integrated Intel or AMD GPU is not counted by NVML, so a one-card PC is not affected; an unknown count (-1) does not refuse, as before.
Tests
cmake --workflow --preset ci: builds with/W4 /WX; core_tests and app_tests pass. The count rules are covered by the existingdecide_boot/several_gpustests;saved_tune_foritself readsgao.jsonand has no unit test.🤖 Generated with Claude Code