Repository navigation
fix(cli): gao --status advises the retest after a driver update - #71
Merged
Merged
Conversation
The driver line said "CHANGED -- run `gao --optimize` again", a 40-minute run, where the logon apply advises the five-minute retest. Both now use one advice (kDriverChangedAdvice). The line also names the driver the tune was tested on, and an unreported version no longer reads as "CHANGED". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After a driver update (seen on the RTX 5070, 617.14 -> 621.14)
gao --statussaid:That is the 40-minute run. The logon apply gives other advice: the five-minute retest, which here passed and saved the tune for 621.14.
What
kDriverChangedAdviceincore/boot.hpp: one text for both places.driver_status(tested_on, now):matches,CHANGED from 617.14 -- test the tune again in the app (5 minutes, orgao --retest), or optimize again, or, when NVML reports no version,NVML did not report it; the tune is not applied at logon(it used to readunknown (CHANGED ...)).decision_text(the logon apply) uses the same advice; its text is unchanged.The
gpu:line still advisesgao --optimize: a retest is for a new driver, not a new card.Tests
cmake --workflow --preset ci: builds with/W4 /WX; core_tests 457/457 and app_tests pass. New test: the advice after an update namesgao --retestand notgao --optimize, a matching driver saysmatches, an unknown one does not sayCHANGED.gao --statusof this build on the RTX 5070 (driver 621.14, after the retest):driver: 621.14 (matches). The changed case was not seen on the card: the driver matches again.🤖 Generated with Claude Code