Repository navigation
fix(gui): a run refused at once shows as not started on the Optimize page - #66
Merged
Merged
Conversation
…page The page went to the run screen only when a frame saw the run running. A refusal (another tuning tool open, Automatic Tuning on, more than one NVIDIA GPU) ends before the next frame, so a click on Optimize showed nothing. The worker now counts the runs it starts, and the page follows every new run, also one that has already ended, to its results. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…log line Wrapping broke the issues link at its dots. A run that did not start also said "Nothing was saved" and pointed at run.log under a reason that already says nothing was changed; it now shows its reason alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Only a refusal (more than one NVIDIA GPU, another tuning tool open, Automatic Tuning on, a run already under way) leaves it out: the user can change that. A fault such as a failed NVML init keeps it, because a bug report needs the log. The refusal texts are named constants now, so app::is_refusal can tell them apart. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #65; merge that one first (GitHub then retargets this PR to main).
Why
The Optimize page went to the run screen only when a frame saw the run running. A refusal ends before the next frame, so a click on Optimize showed nothing. This was not new with #65: MSI Afterburner or RTSS open, Automatic Tuning on, or a run already under way did the same.
What
Snapshot::run_id);follow_runinui.hppfollows every new run, also one that has already ended, to its results: "Not started" with the reason.split_link); wrapping broke it at its dots.app::is_refusal: more than one NVIDIA GPU, another tuning tool, Automatic Tuning, a run already under way) shows its reason alone. A run that failed to start for another reason, such as a failed NVML init, still points at run.log, because a bug report needs it.kAlreadyRunning,kAutoTuningRefusal,kOtherToolRefusalTail); the texts themselves are unchanged.Tests
core_tests 460/460, app_tests 33/33: the screen follows a run refused before any frame saw it, does not jump back after Back, splits links, and tells refusals from faults.
On hardware
On the RTX 5070 with a build forced to count two NVIDIA GPUs, a click on Optimize GPU showed "Not started" with the full refusal, and Back stayed on the choose screen. The link on its own line and the run.log rule were not looked at in the window.
🤖 Generated with Claude Code