Repository navigation
Feat/display selected folder items - #9
Merged
Merged
Conversation
Roverp1
force-pushed
the
feat/display-selected-folder-items
branch
from
June 2, 2026 06:57
bb86094 to
29331f7
Compare
There was a problem hiding this comment.
Pull request overview
This PR extends the TUI dictionary page to display a folder’s child items in the description pane when a folder is selected, and refactors a few service/repository wiring details to rely on shared service injection and adapter barrel exports.
Changes:
- Add
treeItemsOnHoverToDisplaystate and load/display folder children in the description pane when a folder is selected. - Move
FocusStatetyping tomodel/typesand update imports accordingly. - Export
SqliteUserRepositoryvia the adapters DB repositories barrel and simplify the TUI bootstrap import path; updateAuthPageto useuseServices().
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/adapters/db/repositories/index.ts | Exposes SqliteUserRepository via the repositories barrel export. |
| apps/tui/src/pages/dictionary/ui/interactive-list.tsx | Updates FocusState type import location. |
| apps/tui/src/pages/dictionary/ui/description-pane.tsx | Renders folder child items vs. entry descriptions based on selected tree item; consumes new store state. |
| apps/tui/src/pages/dictionary/model/use-dictionary.ts | Adds async loading of folder children into treeItemsOnHoverToDisplay. |
| apps/tui/src/pages/dictionary/model/use-dictionary-store.ts | Adds store state + setter for hovered/selected folder items and adjusts currentFolder selector typing. |
| apps/tui/src/pages/auth/ui/auth-page.tsx | Switches to global useServices() instead of prop-injected authService. |
| apps/tui/src/app/main.tsx | Uses SqliteUserRepository from @dictos/adapters barrel export. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| const { handleCreateDescriptionSubmit } = useCreateLogic(); | ||
|
|
||
| if (!selectedTreeItem) return; |
Comment on lines
+104
to
+106
| {treeItemsOnHoverToDisplay.map((item) => ( | ||
| <text fg={theme.base05}>{item.label}</text> | ||
| ))} |
Comment on lines
134
to
136
| const currentFolder = useDictionaryStore( | ||
| (state) => state.pathStack[state.pathStack.length - 1]! | ||
| (state) => state.pathStack[state.pathStack.length - 1] | ||
| ); |
Comment on lines
+128
to
+131
| useEffect(() => { | ||
| if (selectedTreeItem?.type !== "folder") return; | ||
|
|
||
| const loadItems = async () => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.