Skip to content

[Feat] Add abstract router base class for easier prediction file generation - #23

Merged
jiarong0907 merged 4 commits into
mainfrom
abstract-router
Nov 12, 2025
Merged

jiarong0907 merged 4 commits into
mainfrom
abstract-router

Conversation

@yl231

@yl231 yl231 commented Nov 11, 2025

Copy link
Copy Markdown
Contributor
  • Add BaseRouter abstract class with _get_prediction() method
  • Add ExampleRouter implementation demonstrating router pattern
  • Update generate_prediction_file.py to use router classes
  • Update README with instructions for creating custom routers
  • Add validation to ensure selected models are in the config
  • Fix mypy configuration for namespace packages

- Add BaseRouter abstract class with _get_prediction() method
- Add ExampleRouter implementation demonstrating router pattern
- Update generate_prediction_file.py to use router classes
- Update README with instructions for creating custom routers
- Add validation to ensure selected models are in config
- Fix mypy configuration for namespace packages
@yl231
yl231 requested a review from jiarong0907 November 11, 2025 16:41
Updated README to clarify the modification of the prediction file.
Clarify the requirements for the <your-router> argument and the _get_prediction() method.
Updated README to include line number reference for generate_prediction_file.py.
@jiarong0907 jiarong0907 changed the title Add abstract router base class for easier prediction file generation [Feat] Add abstract router base class for easier prediction file generation Nov 12, 2025

@jiarong0907 jiarong0907 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jiarong0907
jiarong0907 merged commit 4714a9a into main Nov 12, 2025
10 checks passed
@jiarong0907
jiarong0907 deleted the abstract-router branch November 12, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants