[Feat] Add abstract router base class for easier prediction file generation - #23
Merged
Merged
Conversation
yl231
commented
Nov 11, 2025
Contributor
- Add BaseRouter abstract class with _get_prediction() method
- Add ExampleRouter implementation demonstrating router pattern
- Update generate_prediction_file.py to use router classes
- Update README with instructions for creating custom routers
- Add validation to ensure selected models are in the config
- Fix mypy configuration for namespace packages
- Add BaseRouter abstract class with _get_prediction() method - Add ExampleRouter implementation demonstrating router pattern - Update generate_prediction_file.py to use router classes - Update README with instructions for creating custom routers - Add validation to ensure selected models are in config - Fix mypy configuration for namespace packages
Updated README to clarify the modification of the prediction file.
Clarify the requirements for the <your-router> argument and the _get_prediction() method.
Updated README to include line number reference for generate_prediction_file.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.