Fix slideshow controls alignment#16
Closed
MattNotarangelo wants to merge 1 commit intoRopeWiki:masterfrom
Closed
Conversation
- Center page number readout by removing left offset - Align slider with pause button by zeroing asymmetric margins - Round all corners of pause button instead of right side only
Contributor
|
Thanks for addressing this @MattNotarangelo - I hadn't even noticed the problem, but now I do I can't unsee it! It looks like this is solely injecting css. Would it be better to place this in the central css config instead? (The setup is just like js, but for css: https://github.com/RopeWiki/commoncss) |
Contributor
Author
Ah yep good callout. I'll make a new PR there! |
Contributor
Author
|
Moved to commoncss repo (RopeWiki/commoncss#1). Closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small PR to fix the slider alignment
left: -0.3emoffset on.slideshow-nav-readout-11pxtop,7pxbottom) on the jQuery UI sliderui-corner-right)Before

After

Console commands to test before merging: