Skip to content

Fix slideshow controls alignment#16

Closed
MattNotarangelo wants to merge 1 commit intoRopeWiki:masterfrom
MattNotarangelo:fix/slideshow-controls-alignment
Closed

Fix slideshow controls alignment#16
MattNotarangelo wants to merge 1 commit intoRopeWiki:masterfrom
MattNotarangelo:fix/slideshow-controls-alignment

Conversation

@MattNotarangelo
Copy link
Copy Markdown
Contributor

@MattNotarangelo MattNotarangelo commented Apr 2, 2026

Summary

Small PR to fix the slider alignment

  • Centers the page number readout by removing the default left: -0.3em offset on .slideshow-nav-readout
  • Aligns the slider with the pause button by zeroing the asymmetric vertical margins (-11px top, 7px bottom) on the jQuery UI slider
  • Rounds all corners of the pause button evenly instead of only the right side (ui-corner-right)

Before
image

After
image

Console commands to test before merging:

var s = document.createElement('style');
s.innerHTML = '.srf-slideshow .slideshow-nav-readout { left: 0; } .srf-slideshow .slideshow-nav.ui-slider { margin-top: 0; margin-bottom: 0; } .srf-slideshow .slideshow-nav-wrapper .ui-button-icon-only { border-radius: 4px; }';
document.body.appendChild(s);

- Center page number readout by removing left offset
- Align slider with pause button by zeroing asymmetric margins
- Round all corners of pause button instead of right side only
@hcooper
Copy link
Copy Markdown
Contributor

hcooper commented Apr 2, 2026

Thanks for addressing this @MattNotarangelo - I hadn't even noticed the problem, but now I do I can't unsee it!

It looks like this is solely injecting css. Would it be better to place this in the central css config instead? (The setup is just like js, but for css: https://github.com/RopeWiki/commoncss)

@MattNotarangelo
Copy link
Copy Markdown
Contributor Author

Thanks for addressing this @MattNotarangelo - I hadn't even noticed the problem, but now I do I can't unsee it!

It looks like this is solely injecting css. Would it be better to place this in the central css config instead? (The setup is just like js, but for css: RopeWiki/commoncss)

Ah yep good callout. I'll make a new PR there!

@MattNotarangelo
Copy link
Copy Markdown
Contributor Author

Moved to commoncss repo (RopeWiki/commoncss#1). Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants