Conversation
hcooper
requested review from
BenjaminPelletier,
catware2,
dangel-ma,
davantalus and
farnstrom
BenjaminPelletier
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #187
The first PR did work, however it had a race condition, which meant when creating a new condition report the "has condition date" property wasn't being updated (page didn't exist before the refresh) - however when editing an existing one it would. For ease of testing I was just editing condition reports, and didn't pick up on this nuance until afterwards.
This PR switch the extension to use the mediawiki job queue to asynchronously schedule the refresh. The work done is same, it's just executed a few moments later rather than by the extension itself.
Tested in dev, and also in prod (as I thought the race condition might only be in the production environment).
The start delay of 5s is just a little extra guarantee of ordering.