Conversation
hcooper
requested review from
BenjaminPelletier,
catware2,
dangel-ma,
davantalus and
farnstrom
BenjaminPelletier
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes another issue reported to me by multiple users recently.
The reference photo upload system seems to "loose" their photo.
The source of the problem is Get auto-population of "destination filename" working again.
tl;dr - basically the uploaded file was getting renamed from what we expected (
Canyon-date_pic.jpg) to what it was named locally.This only affects uploads done by Page Forms, i.e. condition reports and references, the former doesn't mind as it will use any name it's given. The later expects a particular format.
Inital state - before selecting a file, we prepopulate the dest filename field.
BROKEN - after selecting a file to upload, the dest name gets changed to match your local version.
FIX - file keeps the name the reference system expect.
There's much more to improve in this upload flow (e.g. incorrect max file limit stated, ugly clunky UI, etc) however in future versions this whole custom upload form is going away, so customizing it further now is mostly a waste of time.