[Remove] Drop the decision-model review pre-screen and diff risk hints - #3173
Merged
Merged
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the decision-model pre-screen from pull request reviews and the
get_diff_risk_hintstool built on it (added in #3119, #3130, and #3141).Why
A paired eval found that the hints don't help a reviewer find more bugs, and they may make it miss some.
Setup:
get_diff_risk_hintsfound no case where an agent changed code because of a hint. Later reviews still found bugs inside the hunks it had flagged.The eval reviewer is one model call over the diff, not the full review agent, so this measures what a reviewer notices, not end-to-end review quality. If the signal comes back, it should be an additive pass on the ranked hunks rather than guidance in the main reviewer's prompt.
Changes
review_prescreen, and the review-code skill no longer mentions it.review-prescreen:evalscript.get_diff_risk_hintsMCP tool, its run-token API route, the shared server helper, and the self-review instruction in the implement-changes workflow.No schema or settings changes.