Skip to content

[Improve] One tool row for every integration tool dialog - #3073

Merged
daniel-lxs merged 1 commit into
developfrom
improve/unify-tool-management-rows
Sep 21, 2026
Merged

daniel-lxs merged 1 commit into
developfrom
improve/unify-tool-management-rows

Conversation

@daniel-lxs

@daniel-lxs daniel-lxs commented Sep 21, 2026

Copy link
Copy Markdown
Member

Summary

The two integration tool dialogs drew the same list differently. Built-in integrations used a switch, a readable tool name, and no description; custom MCP servers used a checkbox, the raw tool name in mono, and a description. They were built at different times and nothing tied them together.

Both now render one row from the shared tool list:

  • Checkbox for enable/disable. The change is staged until the dialog's Save, which a switch misrepresents, and it now reads differently from the approval controls beside it, which do save immediately.
  • Readable tool names everywhere ("Resolve Library Id"), with the integration's own name dropped when the tool name repeats it. The raw name stays available as the label's tooltip.
  • Descriptions in both dialogs, clamped to two lines behind Show more.

The row, the name formatting, and the description toggle moved into the shared list, so each dialog passes only its enabled state and toggle handler.

Screenshot

Unified tool row

Testing

  • The dialog's own suite now covers the unified row against the real component (checkbox, readable name with the raw name as its title, description shown, no switch). Tests that pinned the old switch labels and raw names were updated. The settings suites pass.
  • Checked live on a local stack.

@roomote-community

roomote-community Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed 2b12c98

@daniel-lxs
daniel-lxs merged commit 64290d3 into develop Sep 21, 2026
17 checks passed
@daniel-lxs
daniel-lxs deleted the improve/unify-tool-management-rows branch September 21, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant