[Feat] Enforce per-tool approval policies at the integration proxy - #3072
Merged
Merged
Conversation
Contributor
|
No new code issues found. See task
Reviewed e1c1396 |
6 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per-tool approval policies (the
integrationToolApprovalsexperiment, #3001 and #3069) were enforced only inside Sessions. A task calling the same integration tool ran it ungated, and since a Session can launch a task, a call gated in the Session could be handed to a task and run with no approval.A Session can enforce natively because its agent has no shell. A task's agent has a shell next to its MCP configuration, so nothing inside the sandbox can be the boundary there. The integration proxy is the one place every caller crosses, so enforcement goes there:
tools/listand a call to one gets a specific error (for a task's Ask first tool: it needs approval and should be run from a Session), the same way disabled tools are handled.The built-in integration proxy, the Linear proxy, and the custom server proxy all opt in through the shared
createMcpProxy. The experiment's settings copy now says Reject applies to tasks and that Ask first tools are unavailable to them.Not in this PR
Testing