Skip to content

[Fix] Session artifact helpers allow non-human metadata reads - #2594

Merged
roomote-roomote[bot] merged 2 commits into
developfrom
fix/session-artifact-helper-auth-1whina8s7azis
Sep 12, 2026
Merged

[Fix] Session artifact helpers allow non-human metadata reads#2594
roomote-roomote[bot] merged 2 commits into
developfrom
fix/session-artifact-helper-auth-1whina8s7azis

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

​Opened on behalf of @daniel-lxs. Follow up by mentioning @roomote-roomote, in the web UI, or in Telegram.

What changed

  • Enforce the canonical readable-Session policy inside Session artifact path and version helpers before querying artifact metadata.
  • Reject deployment-principal auth without a human user while preserving deployment-collaborative direct-link reads for authenticated members.
  • Add real-database regression coverage for direct helper calls that previously ignored their auth argument.

Why this change was made

The live tRPC callers already authorize Session reads, but the exported helpers accepted an auth context without enforcing it. Checking again at the data-access boundary prevents direct or future internal callers from bypassing the established Session policy.

Impact

No user-facing behavior change is intended for authorized Session reads. This adds defense in depth without removing the existing caller checks; 31 focused artifact tests, web TypeScript, web ESLint, changed-file formatting/lint, and the full pre-push gates pass.

@roomote-roomote
roomote-roomote Bot marked this pull request as ready for review September 12, 2026 07:00
@roomote-community

roomote-community Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

No new code issues found. See task

Reviewed 51ca293

@roomote-roomote
roomote-roomote Bot merged commit f09f750 into develop Sep 12, 2026
17 checks passed
@roomote-roomote
roomote-roomote Bot deleted the fix/session-artifact-helper-auth-1whina8s7azis branch September 12, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant