Skip to content

[Fix] Fast widgets fail during BullMQ-resumed turns - #2593

Merged
roomote-roomote[bot] merged 2 commits into
developfrom
fix/bullmq-show-widget-packaging-0qbrgixsrfyio
Sep 12, 2026
Merged

[Fix] Fast widgets fail during BullMQ-resumed turns#2593
roomote-roomote[bot] merged 2 commits into
developfrom
fix/bullmq-show-widget-packaging-0qbrgixsrfyio

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

​Opened on behalf of @daniel-lxs. Follow up by mentioning @roomote-roomote, in the web UI, or in Telegram.

What changed

  • Emit JSDOM's synchronous XHR helper beside the bundled BullMQ entrypoint so Fast show_widget sanitization can resolve it during resumed turns.
  • Declare JSDOM directly in the BullMQ package so its build configuration resolves only dependencies owned by that workspace.
  • Add a real built-artifact regression test that runs the BullMQ tsup configuration and verifies the helper resolves from the generated bundle location.
  • Fail the final application image build if the helper does not reach the BullMQ runtime directory.

Why this change was made

JSDOM retains a runtime require.resolve("./xhr-sync-worker.js") inside the bundled BullMQ entrypoint. BullMQ previously emitted only dist/index.js, so Fast turns resumed by BullMQ failed when show_widget initialized the sanitizer even though API-owned Fast turns had the complete external JSDOM package available.

Impact

Fast widgets can render during BullMQ-resumed turns without a missing-module failure. The fix does not change widget sanitization or UI behavior; it restores the required runtime asset and adds build-time coverage. The build also works from BullMQ's declared dependency boundary rather than relying on root installation layout. All BullMQ tests and repository pre-push checks pass. Full Docker image assembly was not available in the task sandbox because it has no Docker daemon, so the final-stage file assertion will run when CI builds the image.

@roomote-community

roomote-community Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

No new code issues found. See task

  • apps/bullmq/tsup.config.ts:7 resolves jsdom without declaring it as a BullMQ dependency, causing the build config to fail under pnpm's package layout.

Reviewed 5be3ee6

Comment thread apps/bullmq/tsup.config.ts
@roomote-roomote

roomote-roomote Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor Author

Resolved the missing direct BullMQ dependency in 5be3ee68. @roomote/bullmq now declares the exact JSDOM version used by its build config; frozen install, production build, artifact tests, typecheck, and pre-push checks pass.

@roomote-roomote
roomote-roomote Bot marked this pull request as ready for review September 12, 2026 07:04
@roomote-roomote
roomote-roomote Bot merged commit 4024232 into develop Sep 12, 2026
18 checks passed
@roomote-roomote
roomote-roomote Bot deleted the fix/bullmq-show-widget-packaging-0qbrgixsrfyio branch September 12, 2026 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant