[Fix] Provider environment variables are omitted from deployed services - #2592
Open
roomote-roomote[bot] wants to merge 4 commits into
Open
[Fix] Provider environment variables are omitted from deployed services#2592roomote-roomote[bot] wants to merge 4 commits into
roomote-roomote[bot] wants to merge 4 commits into
Conversation
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 12, 2026 06:44
Contributor
| ); | ||
| } | ||
| expect(compose).toContain( | ||
| 'x-roomote-controller-env: &roomote-controller-env\n <<: *roomote-base-env', |
Contributor
There was a problem hiding this comment.
This assertion codifies a functional regression: the controller's worker launchers call buildBaseWorkerEnv, which reads R_MODEL and R_MODEL_ENV_KEYS from the controller process to pass the deployment's default model configuration (and non-gateway custom provider values) to sandboxes. The bare base anchor removes those values, so deployed jobs no longer inherit the operator's env-configured model setup. Preserve a launcher-safe inference subset instead of requiring *roomote-base-env here.
Contributor
Author
There was a problem hiding this comment.
Tracing the controller launcher environment contract and preparing the smallest least-privilege fix on the existing PR branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
The runtime resolver already supports these provider variables, but the deployment templates omitted them before application processes started. The controller does not consume control-plane inference credentials, so giving it the shared inference environment would unnecessarily broaden secret access and violates the production Compose security contract.
Impact
Environment-based provider configuration reaches the model-aware web, API, and BullMQ production services and local PM2 processes without exposing provider credentials to the production controller. Provider model behavior, credential precedence, and compatibility handling are unchanged.
Validation
@roomote/devtypecheck, targeted oxlint and oxfmt checks, andgit diff --checkpassed.