Skip to content

[Fix] Telegram review buttons persist after user actions - #2587

Merged
daniel-lxs merged 1 commit into
developfrom
fix/telegram-pr-review-buttons-2lr5gmnz51tyx
Sep 12, 2026
Merged

[Fix] Telegram review buttons persist after user actions#2587
daniel-lxs merged 1 commit into
developfrom
fix/telegram-pr-review-buttons-2lr5gmnz51tyx

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

​Opened on behalf of @daniel-lxs. Follow up by mentioning @roomote-roomote, in the web UI, or in Telegram.

What changed

  • Retire Telegram PR review controls through the shared managed-footer path after callback actions and typed replies, clearing both the Bot API reply markup and persisted footer buttons under the footer lock.
  • Render Fast-parent Telegram review actions as Resolve on the first row and Auto-resolve plus Dismiss on the second row.
  • Cover successful Auto-resolve handling and the full Telegram carrier lifecycle, including the initial Bot API payload, retirement, and a later footer relocation that must not restore the keyboard.

Why this change was made

Telegram callbacks removed only the live reply markup, leaving the managed-footer record's button snapshot intact. A later footer edit could therefore restore stale controls, while the Fast-parent path also retained the older single-row layout because the prior layout change covered only direct notifications.

Impact

Telegram PR review buttons disappear immediately and stay retired after an action, including across later footer updates or carrier relocation. Fast-parent notifications now use the intended one-plus-two row layout; Slack, Discord, Teams, and web behavior are unchanged.

@roomote-community

roomote-community Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed b57fcfc

@roomote-roomote
roomote-roomote Bot marked this pull request as ready for review September 12, 2026 05:50
@daniel-lxs
daniel-lxs merged commit 1c06930 into develop Sep 12, 2026
17 checks passed
@daniel-lxs
daniel-lxs deleted the fix/telegram-pr-review-buttons-2lr5gmnz51tyx branch September 12, 2026 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant