[Fix] AgentMail formatting can stall on crafted markdown - #2583
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
[Fix] AgentMail formatting can stall on crafted markdown#2583roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
![roomote-community[bot]](https://avatars.githubusercontent.com/u/211522643?s=60&v=4){kind=small}
| function stripInlineMarkdown(text: string): string { | ||
| return text | ||
| .replace(/\[([^\]\n]+)\]\(([^\s)]+)\)/g, '$1 ($2)') | ||
| return replaceMarkdownLinksWithText(text) |
Contributor
There was a problem hiding this comment.
The forward parser is only used by the plain-text formatter. renderAgentMailHtml() still reaches convertInlineMarkdown()'s original link regex, so buildAgentMailEmailBody() continues to do quadratic work on the crafted [label]( input before it generates the text alternative. Apply the parser (or a shared linear tokenizer) to the HTML path as well and add HTML coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Replaced the ambiguous AgentMail plain-text markdown link and heading expressions with forward-only parsers. Added regression coverage for ordinary output, unsafe protocols, maximum-size malformed links, and long heading whitespace.
Why this change was made
Crafted email content could trigger polynomial regular-expression work while formatting outbound plain-text bodies. The new parsing path processes each input region once without suppressing the security findings.
Impact
AgentMail preserves its existing HTML and plain-text markdown output while handling adversarial input in linear time.
Linked work items