[Fix] Session prompt loses focus when task panels expand - #2533
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
[Fix] Session prompt loses focus when task panels expand#2533roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
| @@ -216,7 +209,6 @@ export function sessionWorkspacePanelReducer( | |||
| (taskId) => taskId !== action.selectedTaskId, | |||
| ), | |||
| taskArtifacts: {}, | |||
Contributor
There was a problem hiding this comment.
Opening side-by-side from the native Button moves browser focus to that button before this reducer runs. This action now removes the task-focus request but never restores the Session composer, so a real pointer click still interrupts typing (the new fireEvent.click test does not emulate native focus transfer). Preserve the existing prompt focus on pointer activation, or explicitly restore it after the panels mount.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
Expanding task panels reused the explicit task-selection focus path, unexpectedly moving users away from the Session composer even though they had not selected a task.
Impact
Sessions can display running tasks side by side without interrupting typing in the main prompt. Direct task selection and Alt/Option + Arrow prompt navigation retain their existing behavior.