[Feat] Show when Slack app upgrades are required - #2458
Draft
roomote-roomote[bot] wants to merge 2 commits into
Draft
[Feat] Show when Slack app upgrades are required#2458roomote-roomote[bot] wants to merge 2 commits into
roomote-roomote[bot] wants to merge 2 commits into
Conversation
Contributor
Comment on lines
+173
to
+175
| OPENCODE_AUTH_CONTENT_ENV_VAR_NAME, | ||
| SLACK_MANIFEST_APP_ID_ENV_VAR_NAME, | ||
| SLACK_MANIFEST_VERSION_ENV_VAR_NAME, |
Contributor
There was a problem hiding this comment.
ROOMOTE_MANAGED_ENV_VAR_NAMES is only enforced by the generic editor. Task startup redacts persisted deployment variables exclusively through CONTROL_PLANE_ENV_VAR_NAMES (fetchEnvVars / fetchResolvedRuntimeEnvVars), so both newly persisted R_SLACK_MANIFEST_* values are injected into every task sandbox. That contradicts this block's “task sandboxes never receive them” contract and leaks deployment-specific Slack metadata to untrusted tasks. Add these names to the control-plane/redaction set as well, with a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
Slack app capabilities evolve independently from product releases. Persisted version evidence lets Roomote tell admins when their installed app needs a manifest update without guessing from Slack APIs or treating credential validation as a successful upgrade.
Impact
Existing installations start with an unknown version and show Upgrade available until a manifest export confirms they are current or the update and required reinstall complete. Newly generated apps and confirmed updates record their version automatically; future manifest requirement changes only need to bump the shared Slack manifest version constant.
Screenshots