feat: add ValueEqualityCollection<T> - #11
Merged
Merged
Conversation
Ronto4
added a commit
to Ronto4/TransitUI
that referenced
this pull request
Jul 6, 2025
However, connections are broken: 1. Whenever there are mutlitple trips combining into running on all related days, they are not found as they do not pass the equality check on having identical DaysOfOperation, leaving the `Single` call without matching elements. 2. Having two trips on different days on the same route and time with different connections works in the existing system. However, when collapsing trips to fix point 1 those two would be collapsed as well, breaking everything. 3. Grouping by all the stuff except for DaysOfOperation currently does not work as value equality collections have not yet been implemented. Conclusion: Value equality collections (Ronto4/R4Utils#11) need to be incorporated first. Then, grouping can be applied, solving this issue at its root. With some luck this might even make timetable views easier as some steps of collapsing will already have happened. [skip ci]
Ronto4
force-pushed
the
feat/value-equality-collection
branch
from
July 8, 2025 21:24
bb724fa to
c52ca1d
Compare
This is a collection (implements `ICollection<T>`) that uses equality of its elements for comparing it against other instances.
Ronto4
force-pushed
the
feat/value-equality-collection
branch
from
July 8, 2025 21:34
c52ca1d to
a3f7f9b
Compare
Ronto4
marked this pull request as ready for review
July 8, 2025 21:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a collection (implements
ICollection<T>) that uses equality of its elements for comparing it against other instances.