fix: inherit extra roots on new chats; stop Import resurrecting deleted sessions - #1237
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1233
Fixes #1236
Why
Open issues this round: 2 bugs, 3 features. Features stay parked.
#1233 extra-root write still failed on 0.2.36. The bound session used
app_ws_*; a new chat in the same project had noworkspaceId, so spawn fell back to built-inworkspaceand Seatbelt blocked the extra folder.#1236 archive does not resurrect (the App row still links
agentSessionId). Delete only dropped the App journal, so the next bulk Import created a new sidebar row for the leftover CLI directory.What
import_allcannot recreate the row.CLI …stubs and System32 /workspaces/generalcwd noise.Out of scope
grok sessions listunchangedTests
bind_default_workspace_if_unbound_inherits_project_workspacefork_session_copies_workspace_bindingimport_all_does_not_resurrect_deleted_app_sessionimport_all_skips_tombstoned_id_even_if_cli_dir_remainsarchived_row_is_already_linked_so_import_all_skipsskip_bulk_import_drops_stubs_and_noise_cwds