Skip to content

fix: inherit extra roots on new chats; stop Import resurrecting deleted sessions - #1237

Merged
RongleCat merged 2 commits into
mainfrom
fix/session-workspace-inherit-and-cli-delete
Sep 21, 2026
Merged

RongleCat merged 2 commits into
mainfrom
fix/session-workspace-inherit-and-cli-delete

Conversation

@RongleCat

Copy link
Copy Markdown
Owner

Fixes #1233
Fixes #1236

Why

Open issues this round: 2 bugs, 3 features. Features stay parked.

#1233 extra-root write still failed on 0.2.36. The bound session used app_ws_*; a new chat in the same project had no workspaceId, so spawn fell back to built-in workspace and Seatbelt blocked the extra folder.

#1236 archive does not resurrect (the App row still links agentSessionId). Delete only dropped the App journal, so the next bulk Import created a new sidebar row for the leftover CLI directory.

What

  • New chats (and connect of still-unbound rows) inherit the project's workspace; forks copy the source binding.
  • Delete stops live/background/parked ACP, removes the CLI session tree, and tombstones the agent id so import_all cannot recreate the row.
  • Bulk import also skips CLI … stubs and System32 / workspaces/general cwd noise.

Out of scope

Tests

  • bind_default_workspace_if_unbound_inherits_project_workspace
  • fork_session_copies_workspace_binding
  • import_all_does_not_resurrect_deleted_app_session
  • import_all_skips_tombstoned_id_even_if_cli_dir_remains
  • archived_row_is_already_linked_so_import_all_skips
  • skip_bulk_import_drops_stubs_and_noise_cwds

New chats in a project pick up that project's extra roots so extra-root
write is not stuck on the first bound session. Deleting a chat stops ACP,
removes the linked CLI directory, and tombstones the agent id so Import
cannot recreate the sidebar row.

Fixes #1233
Fixes #1236
Store a sentinel workspace id when the user detaches extra folders so
reconnect does not re-inherit the project default. Archive confirms
that only the App sidebar hides; the CLI list is unchanged.

Also records research for #1232 / #1234 / #1235 (not implemented).
@RongleCat
RongleCat merged commit 699730b into main Sep 21, 2026
4 checks passed
@RongleCat
RongleCat deleted the fix/session-workspace-inherit-and-cli-delete branch September 21, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: 共享模式下归档/删除不联动 CLI 目录,导入会重生重复会话 [Bug]: 附加根写入失败

1 participant