Remove dead scope-none rules, fix stale CDS-SEC docs - #443
Merged
RonaldHensbergen merged 4 commits intoAug 23, 2026
Conversation
Co-authored-by: RonaldHensbergen <22539616+RonaldHensbergen@users.noreply.github.com>
Co-authored-by: RonaldHensbergen <22539616+RonaldHensbergen@users.noreply.github.com>
…flicts-443 Co-authored-by: RonaldHensbergen <22539616+RonaldHensbergen@users.noreply.github.com>
RonaldHensbergen
force-pushed
the
fix/security-rule-cleanup
branch
from
August 23, 2026 12:49
0a199f4 to
72824b2
Compare
RonaldHensbergen
approved these changes
Aug 23, 2026
RonaldHensbergen
left a comment
Owner
There was a problem hiding this comment.
Reviewed the diff (CHANGELOG, cli/resources/rule-set.json, cli/image_verification.py, docs/image-signing.md, docs/threat-model.md, docs/vm-postgres-odbc-access.md, tests/test_image_verification.py, tests/test_preflight.py, tests/test_security.py).
- Deletion of CDS-SEC-050/051/052/053/054 from rule-set.json is clean — no dangling commas/whitespace, JSON still valid, schema still validates.
- CDS-SEC-006/032 correctly flipped to enabled:false; new test_no_scope_none_rule_is_enabled regression guard in test_security.py enforces this going forward.
- Docs (image-signing.md, threat-model.md, vm-postgres-odbc-access.md) and the image_verification.py docstring are consistently updated to stop citing the deleted rule IDs while correctly noting image_verification.py still emits findings under CDS-SEC-050/051/052.
- New regression tests (#354, #355, #397) pass; ran the full targeted suite (test_security, test_image_verification, test_preflight) against this exact branch — 87/87 pass.
- No stale references to the deleted rule IDs remain anywhere in the tree.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Delete unused CDS-SEC-050/051/052/053/054 from the bundled rule set (enforcement lives in
cli/image_verification.py). Disable CDS-SEC-006/032 so noscope: ["none"]rule appears active. Add regression guards for #354, #355, #397. Fix stale docs.Closes #354, Closes #355, and Closes #397
Type Of Change
User Impact
N/A
Validation
Checklist