Refactor display handling - #60
Merged
Merged
Conversation
RomanAlexandroff
left a comment
Owner
Author
There was a problem hiding this comment.
Minor finding: RTC cache variables are defined in the display_handling.h header. Safe only if the header is never included elsewhere, but fragile.
Overall: display refactor looks much better. There're more functions now than before, but each one of them is responsible for its own single thing instead of how all the logic used to be wildly stuffed in one overloaded function. Drawing images in the Exam mode used to live in its "separate world" from the Cluster number mode, but now everything goes through the same logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors display rendering into a single unified
draw_on_display(IMAGE_t)API. It centralises display state tracking, prevents repeated redraws of unchanged images and routes cluster, exam, OTA, battery, and Telegram/error display updates through the same display-handling flow. Now display handling logic is much more straightforward, easy to understand and support. Resolves #28It also fixes pre-exam handling so the device does not enter a long blocking synchronisation wait when exam mode is reached too early.
Notes