Skip to content

[Issue] Possibility of unauthorised Telegram chat takeover #35

Description

@RomanAlexandroff

Problem

sender_handling() always overwrites saved chat_id with the sender of the latest message. Any Telegram user who can message the bot can become the authorised chat. Even though sender_handling() notifies the Telegram chat that chat_id has been changed and allows you to change it back, it is still not a sufficient protection.

Expected behaviour

Only an authorised user or explicit pairing flow should be able to change the saved Telegram chat ID.

Suggested fix

Require a pairing/reset command, admin confirmation, or only allow auto-binding when the stored chat ID is still the initial placeholder.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions