Failure Screenshots Dir

[OutlawAndy]

Motivation

Ultimately, I just want to able to both use rails tmp:clear to delete local capybara artifacts & also have them accessible to me via download when CI fails. We could accomplish this a number of ways, so feel to propose another if you prefer.

Why

While recent versions of Capybara seem to use tmp/capybara as the directory where they store screenshots, the Rails tmp:clear command will not clear this directory. For that reason, I prefer to configure capybara to save failure screenshots into the traditional directory which rails expects:

Capybara.configure do |config|
  config.test_id = 'data-testid'
  config.automatic_label_click = true
  config.save_path = './tmp/screenshots'
end

Changes

• Add input for failure-screenshot-dir with default value set to tmp/capybara
• pass this input as the input into actions/upload-artifact
• Update README to demo usage of new input
• General README improvements. see line comments

Screenshots

[OutlawAndy]

1. use of always() doesn't make sense with a conditional.
2. checking cache-hit is unnecessary, because the compile_assets action will report 'success' so long as it did not fail, whether it actually compiled or there was a cache hit.
3. if is redundant because compile_assets is specified as a "need" for the system-test job. i.e. system-test will be skipped if compile_assets fails.

reference: https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#jobsjob_idneeds